On 02/15/2011 03:33 AM, Matthias Bolte wrote: >>>>> PACKAGE_VERSION and PACKAGER are all defined as "" by default, >> do we need to do more checking to print just the following? >> > > configure tests --with-packager(-version) for "no" instead of empty > string. I think --with-packager(-version) should either default to > "no" > diff --git a/configure.ac b/configure.ac > index 3cd824a..9caa902 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -32,11 +32,11 @@ AC_SUBST([LIBVIRT_VERSION_NUMBER]) > AC_ARG_WITH([packager], > [AS_HELP_STRING([--with-packager], > [Extra packager name])], > - [],[]) > + [],[with_packager=no]) > AC_ARG_WITH([packager-version], > [AS_HELP_STRING([--with-packager-version], > [Extra packager version])], > - [],[]) > + [],[with_packager_version=no]) > if test "x$with_packager" != "xno" > then > AC_DEFINE_UNQUOTED([PACKAGER], ["$with_packager"], I like this approach better. Consider this a pre-approved ACK. > +++ b/configure.ac > @@ -37,12 +37,12 @@ AC_ARG_WITH([packager-version], > [AS_HELP_STRING([--with-packager-version], > [Extra packager version])], > [],[]) > -if test "x$with_packager" != "xno" > +if test "x$with_packager" != "x" No, because ./configure --without-packager-version is shorthand for ./configure --with-packager-version=no, which means $with_packager is not the empty string. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list