On 02/14/2011 02:57 PM, Laine Stump wrote: > On 02/14/2011 04:37 PM, Eric Blake wrote: >> clang complained that STREQ(group->controllers[i].mountPoint,...) was >> a NULL dereference when i==VIR_CGROUP_CONTROLLER_CPUSET, because it >> assumes the worst about virCgroupPathOfController. Marking the >> argument const doesn't yet have an effect, per this clang bug: >> http://llvm.org/bugs/show_bug.cgi?id=7758 >> >> So, we use sa_assert, which was designed to shut up false positives >> from tools like clang. >> >> * src/util/cgroup.c (virCgroupMakeGroup): Teach clang that there >> is no NULL dereference. >> + /* As of Feb 2011, clang can't see that the above function >> + * call did not modify group. */ >> + sa_assert(group->controllers[i].mountPoint); >> > > ACK. Thanks; pushed. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list