On Wed, Feb 02, 2011 at 09:18:25 -0700, Eric Blake wrote:
> On 02/02/2011 08:49 AM, Jiri Denemark wrote:
> > +enum {
> > + VIR_DOMAIN_QEMU_MONITOR_COMMAND_DEFAULT = 0,
> > + VIR_DOMAIN_QEMU_MONITOR_COMMAND_HMP = (1 << 0), /* cmd is in HMP */
> > +} virDomainQemuMonitorCommandFlags;
> > +
> > int virDomainQemuMonitorCommand(virDomainPtr domain, const char *cmd,
> > char **result, unsigned int flags);
>
> Aren't you glad we included the flags parameter when first adding the
> API? Makes life a lot easier when you don't have to add a new API.
Oh yes. All new APIs should be added with the flags parameter.
> ACK with that nit fixed.
Thanks. I realized I also forgot to document the new flag in virsh man page so
I decided to send a v2 so that the documentation is reviewed as well.
Jirka
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list