On 02/02/2011 03:52 AM, Daniel P. Berrange wrote: > On Tue, Feb 01, 2011 at 05:37:10PM -0700, Eric Blake wrote: >> * src/qemu/THREADS.txt: Improve documentation. >> --- >> >> qemuDomainObjExitMonitor() >> - - Acquires the virDomainObjPtr lock >> - Releases the qemuMonitorObjPtr lock >> + - Acquires the virDomainObjPtr lock >> >> But I'm wondering if that was correct, or if the code should instead >> be swapped to match the original ordering in the documentation. > > Either way doesn't matter. The lock ordering constraints only > apply to sequences of 'lock' operations. You can 'unlock' any > lock in any order, providing you always honour the 'lock' > order. So changing the docs is fine. Good to know. > >> src/qemu/THREADS.txt | 100 ++++++++++++++++++++++++++++++++++++++----------- >> 1 files changed, 77 insertions(+), 23 deletions(-) > > ACK Thanks; pushed. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list