On 02/01/2011 09:22 AM, Niels de Vos wrote:
> - virBufferVSprintf(buf, ",bus=pci.0,addr=0x%x", info->addr.pci.slot);
> + if (qemuCmdFlags & QEMUD_CMD_FLAG_PCI_MULTIBUS)
> + virBufferVSprintf(buf, ",bus=pci.0,addr=0x%x", info->addr.pci.slot);
> + else
> + virBufferVSprintf(buf, ",bus=pci,addr=0x%x", info->addr.pci.slot);
I probably would have done:
virBufferVSprintf(buf, ",bus=pci%s,addr=0x%x",
qemuCmdFlags & QEMU_CMD_FLAG_PCI_MULTIBUS ? ".0", "",
info->addr.pci.slot);
to avoid the if/else, but that's not worth changing.
Agree with danpb's ack.
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list