Re: [PATCH] qemu: More clear error parsing domain def failure of tunneled migration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ä 2011å01æ31æ 18:50, Daniel P. Berrange åé:
On Sun, Jan 30, 2011 at 04:46:39PM +0800, Osier Yang wrote:
* src/qemu/qemu_driver.c
---
  src/qemu/qemu_driver.c |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 84d339b..929dc94 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -8014,7 +8014,8 @@ qemudDomainMigratePrepareTunnel(virConnectPtr dconn,
      if (!(def = virDomainDefParseString(driver->caps, dom_xml,
                                          VIR_DOMAIN_XML_INACTIVE))) {
          qemuReportError(VIR_ERR_OPERATION_FAILED,
-                        "%s", _("failed to parse XML"));
+                        "%s", _("failed to parse XML, libvirt version may be "
+                                "diffrent between source and destination host"));
          goto cleanup;


NACK, this code is already broken. The virDomainDefParseString()
method *already* reported the real problem. This call to
qemuReportError() is overwriting the real error message with
something that is useless. The qemuReportError() call needs
to just be deleted entirely.

Oops, As it's already pushed, so will make another patch to remove
qemuReportError(), Thanks.

Regards
Osier

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]