On 01/28/2011 07:40 PM, Osier Yang wrote: > I'm afraid changing on virStrToLong_u* will affect other codes, pretty > codes use them. > >> >>> Is there some codes that expects virStrToLong_{ui,ul,ull} to convert >>> the negative to {ui, ul, ull}? >> >> Probably, given the above arguments about -1 being useful shorthand for >> the maximum value. >> > > Yeah, so are you agreed with danpb? making changes on docs? Yes, I think documenting that negative values are shorthand and wrapped around to positive is the right thing to do here. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list