Re: [PATCH] esx: Ensure max-memory has 4 megabyte granularity

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/1/28 Eric Blake <eblake@xxxxxxxxxx>:
> On 01/28/2011 02:16 PM, Matthias Bolte wrote:
>> ---
>> Âsrc/esx/esx_driver.c | Â Â3 ++-
>> Â1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
>> index 61c2371..c66df0e 100644
>> --- a/src/esx/esx_driver.c
>> +++ b/src/esx/esx_driver.c
>> @@ -2059,8 +2059,9 @@ esxDomainSetMaxMemory(virDomainPtr domain, unsigned long memory)
>> Â Â Â Â Âgoto cleanup;
>> Â Â Â}
>>
>> + Â Â/* max-memory must be a multiple of 4096 kilobyte */
>> Â Â Âspec->memoryMB->value =
>> - Â Â ÂVIR_DIV_UP(memory, 1024); /* Scale from kilobytes to megabytes */
>> + Â Â ÂVIR_DIV_UP(memory, 4096) * 4; /* Scale from kilobytes to megabytes */
>
> ACK (but obviously depends on your other patch, which I'm still reviewing)
>

Thanks, pushed.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]