On Mon, Jan 24, 2011 at 02:14:48PM -0700, Eric Blake wrote: > On 01/24/2011 01:57 PM, David Allan wrote: > > Per the discussion in: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=670394 > > > > The port numbering should start from 1, not 0. We assign maxport + 1, > > so start maxport at 0. > > --- > > src/conf/domain_conf.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > > index d5445a4..08c21e5 100644 > > --- a/src/conf/domain_conf.c > > +++ b/src/conf/domain_conf.c > > @@ -5328,7 +5328,7 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps, > > > > if (chr->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL && > > chr->info.addr.vioserial.port == 0) { > > - int maxport = -1; > > + int maxport = 0; > > ACK. Thanks, pushed. Dave -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list