On 01/24/2011 11:22 AM, Eric Blake wrote: > On 01/24/2011 09:15 AM, Cole Robinson wrote: >> The important thing is to keep a consistent API here, we don't want some >> <sound> devs require tweaking codecs but not others. Steps I see to >> accomplishing this: >> >> - every <sound> device has a <codec type='default'/> (unless codecs are >> manually specified) >> - <codec type='none'/> is required to specify 'no codecs' >> - new audio settings like mic=on|off could then be exposed in >> <sound> or <codec> in a consistent manner for all sound models >> >> v2: >> Use model='ich6' >> >> v3: >> Use feature detection, from eblake >> Set codec id, bus, and cad values >> >> v4: >> intel-hda isn't supported if -device isn't available > > But still no typo fixes. > >> - /* Hack for 2 wierdly unusal devices name in QEMU */ >> + /* Hack for wierdly unusal devices name in QEMU */ > > (see my review at > https://www.redhat.com/archives/libvir-list/2011-January/msg00929.html) > Argh, sorry. Not intentional, I just keep forgetting that piece. Resent with that change. Thanks, Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list