On 01/16/2011 09:39 PM, Osier Yang wrote: > "getCompressionType" trys to throw error when invalid dump image > format is specified, or the compression program for the specified > image format is not available, but at the same time, it returns > enum qemud_save_formats, as a result, upper function will think > it was successful, and disgard to check the error, this fix makes > changes so that it returns -1 on FAILURE, And to be consistent with > "save", won't use "raw" as the default dump format anymore. > > * src/qemu/qemu_driver.c > - rename "getCompressionType" to "getDumpType" > - return -1 on FAILURE > > --- > src/qemu/qemu_driver.c | 40 +++++++++++++++++++++++++--------------- > 1 files changed, 25 insertions(+), 15 deletions(-) This reverts commit 1b6f13bb7002d by Hu Tao that explicitly falls back to RAW on purpose if a compression program cannot be found. We need more justification why we are reverting a prior patch, and consensus on the correct behavior, before this can be applied. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list