2011/1/14 Eric Blake <eblake@xxxxxxxxxx>:
> virLibConnError already includes __FUNCTION__ in its output, so we
> were redundant. ÂFurthermore, clang warns that __FUNCTION__ is not
> a string literal (at least __FUNCTION__ will never contain %, so
> it was not a security risk).
> @@ -344,8 +344,16 @@ virGetDomain(virConnectPtr conn, const char *name, const unsigned char *uuid) {
> Â Â virDomainPtr ret = NULL;
> Â Â char uuidstr[VIR_UUID_STRING_BUFLEN];
>
> - Â Âif ((!VIR_IS_CONNECT(conn)) || (name == NULL) || (uuid == NULL)) {
> - Â Â Â ÂvirLibConnError(VIR_ERR_INVALID_ARG, __FUNCTION__);
> + Â Âif (!VIR_IS_CONNECT(conn)) {
> + Â Â Â ÂvirLibConnError(VIR_ERR_INVALID_ARG, _("no connection"));
> + Â Â Â Âreturn(NULL);
> + Â Â}
Small cosmetic nit: "return isn't a function". I know you just keep in
line with the existing style in this file :)
ACK.
Matthias
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list