> <interface type="network">
> <model type="virtio"/>
> <driver name="vhost"/>
>
> will force use of vhost-net (if it's not available, the domain will
> fail to start). if driver name="qemu", vhost-net will not be used even
> if it is available.
>
> Changes from V1:
>
> enum now starts at 0 instead of -1. I just disallow "default" when
> parsing. This eliminates the need for vhost_specified.
>
> Removed superfluous 3rd arg to open().
Thanks for those fixes.
> @@ -2559,6 +2567,19 @@ virDomainNetDefParseXML(virCapsPtr caps,
> model = NULL;
> }
>
> + if ((backend != NULL) &&
> + (def->model && STREQ(def->model, "virtio"))) {
> + int b;
> + if (((b = virDomainNetBackendTypeFromString(backend)) < 0) ||
> + (b == 0)) {
I probably would have done either this shorthand:
(b = virDomain...FromString) <= 0
or, keeping the long form, used a symbolic name rather than a magic number:
(b = virDomain...FromString) < 0 ||
(b == VIR_DOMAIN_NET_BACKEND_TYPE_DEFAULT)
But that's just style, so up to you if you want to make a tweak, or keep
it as-is.
ACK.
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list