Re: [PATCH] conf: Report error if invalid type specified for character device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/09/2011 04:18 AM, Osier Yang wrote:
> If invalid type is specified, e.g.
> <serial type='foo'>
>     <target port='0'/>
> </serial>
> 
> We replace 'foo' with "null" type implicitly, without reporting an
> error message to tell the user, and "start" or "edit" the domain
> will be success.
> 
> It's not good to guess what the user wants, This patch is to fix
> the problem.
> 
> * src/conf/domain_conf.c

ACK, and pushed (by the way, I noticed the same problem while working on
my <smartcard> XML patches, but you posted first).

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]