On 01/06/2011 11:21 AM, Eric Blake wrote: > On 01/06/2011 05:35 AM, Daniel P. Berrange wrote: >> The current security driver usage requires horrible code like >> >> if (driver->securityDriver && >> driver->securityDriver->domainSetSecurityHostdevLabel && >> driver->securityDriver->domainSetSecurityHostdevLabel(driver->securityDriver, >> vm, hostdev) < 0) > > This is a v2 of the earlier > https://www.redhat.com/archives/libvir-list/2010-November/msg00984.html, > but omits the rest of the 8-patch series that v1 was included with. > That's okay, but I'm a bit curious on the progress of the rest of that > series (in part because it involved adding virCommand handshaking, where > I'm not sure if I need to lend a hand at getting that in) :) Also lacking - my review of v1 pointed out[1] that this failed 'make syntax-check' and 'make check'; and that still appears to be the case with this v2. [1] https://www.redhat.com/archives/libvir-list/2010-November/msg01079.html -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list