2010/12/31 Eric Blake <eblake@xxxxxxxxxx>: > On 12/24/2010 08:42 AM, Eric Blake wrote: >> As pointed out in https://bugzilla.redhat.com/show_bug.cgi?id=659855#c9, >> commit c3568ec2 introduced a regression where we no longer close any >> fd's beyond FD_SETSIZE. >> >> * src/util/util.c (__virExec): Continue to close fd's beyond >> keepfd range. >> Reported by Stefan Praszalowicz. > > Ping - this is a regression bug fix; anyone willing to review it in time > for inclusion in 0.8.7? > >> +++ b/src/util/util.c >> @@ -570,7 +570,7 @@ __virExec(const char *const*argv, >> Â Â Â Â Â Â Âi != null && >> Â Â Â Â Â Â Âi != childout && >> Â Â Â Â Â Â Âi != childerr && >> - Â Â Â Â Â Â(!keepfd || (i < FD_SETSIZE && !FD_ISSET(i, keepfd)))) { >> + Â Â Â Â Â Â(!keepfd || i >= FD_SETSIZE || !FD_ISSET(i, keepfd))) { >> Â Â Â Â Â Â Âtmpfd = i; >> Â Â Â Â Â Â ÂVIR_FORCE_CLOSE(tmpfd); >> Â Â Â Â Â} > ACK. Matthias -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list