On 12/23/2010 12:40 PM, Jiri Denemark wrote:
> Two of the tests we want to skip are C tests and since we moved
> compiling tests to make check phase, replacing compiled binary with a
> no-op shell script before running make check doesn't really work for
> them. We need to replace the source of such tests.
> ---
> libvirt.spec.in | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index fd99a54..3889f5d 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -700,8 +700,12 @@ cd tests
> for i in nodeinfotest daemon-conf seclabeltest
> do
> rm -f $i
> - printf "#!/bin/sh\nexit 0\n" > $i
> - chmod +x $i
> + if [ -f $i.c ]; then
> + echo 'int main(void) { return 0; }' > $i.c
> + else
> + printf "#!/bin/sh\nexit 0\n" > $i
> + chmod +x $i
> + fi
Do these tests still fail in the latest incarnation? For example, I'm
assuming that this upstream patch was enough to fix the nodeinfotest
failure:
https://www.redhat.com/archives/libvir-list/2010-December/msg00737.html
But if you are sure that all three tests must be skipped, ACK that this
change does the job.
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list