Re: [PATCH] vmware: Fix undefine symbol with loadable drivers enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/12/21 Eric Blake <eblake@xxxxxxxxxx>:
> On 12/21/2010 02:51 PM, Matthias Bolte wrote:
>> All other drivers are explicitly linked to gnulib. The VMware
>> driver lacked this, resulting in mdir_name being an undefine
>> symbol.
>
> That's the minimum impact on glibc. ÂThe impact on other systems like
> mingw would be even bigger, due to lots of missing rpl_ functions.
>
>>
>> Explicitly link the VMware driver to gnulib to fix this.
>> ---
>> Âsrc/Makefile.am | Â Â1 +
>> Â1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/Makefile.am b/src/Makefile.am
>> index 607e391..7ecd3e0 100644
>> --- a/src/Makefile.am
>> +++ b/src/Makefile.am
>> @@ -633,6 +633,7 @@ endif
>> Âlibvirt_driver_vmware_la_CFLAGS = \
>> Â Â Â Â Â Â Â -I@top_srcdir@/src/conf -I@top_srcdir@/src/vmx
>> Âif WITH_DRIVER_MODULES
>> +libvirt_driver_vmware_la_LIBADD = ../gnulib/lib/libgnu.la
>
> ACK.
>

Thanks, pushed.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]