Re: [PATCHv2 5/7] tests: avoid spurious failure of nodeinfotest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/12/18 Eric Blake <eblake@xxxxxxxxxx>:
> When running 'make check' under a multi-cpu Dom0 xen machine,
> nodeinfotest had a spurious failure it was reading from
> /sys/devices/system/cpu, but xen has no notion of topology. ÂThe test
> was intended to be isolated from reading any real system files; the
> regression was introduced in Mar 2010 with commit aa2f6f96dd.
>
> Fix things by allowing an early exit for the testsuite.
>
> * src/nodeinfo.c (linuxNodeInfoCPUPopulate): Add parameter.
> (nodeGetInfo): Adjust caller.
> * tests/nodeinfotest.c (linuxTestCompareFiles): Likewise.
> ---
> Âsrc/nodeinfo.c    |  11 ++++++++---
> Âtests/nodeinfotest.c | Â Â5 +++--
> Â2 files changed, 11 insertions(+), 5 deletions(-)
>

ACK.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]