Re: [PATCH 2/6] vbox: Match struct layout of the MSCOM implementation on Windows

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/12/17 Eric Blake <eblake@xxxxxxxxxx>:
> On 12/17/2010 11:56 AM, Matthias Bolte wrote:
>> ---
>> Âsrc/vbox/vbox_CAPI_v2_2.h | Â 20 ++++++++++++++++++++
>> Âsrc/vbox/vbox_CAPI_v3_0.h | Â Â9 +++++++++
>> Âsrc/vbox/vbox_CAPI_v3_1.h | Â Â9 +++++++++
>> Âsrc/vbox/vbox_CAPI_v3_2.h | Â Â9 +++++++++
>> Â4 files changed, 47 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/vbox/vbox_CAPI_v2_2.h b/src/vbox/vbox_CAPI_v2_2.h
>> index 7a94ff5..0543fdd 100644
>> --- a/src/vbox/vbox_CAPI_v2_2.h
>> +++ b/src/vbox/vbox_CAPI_v2_2.h
>> @@ -1563,6 +1563,16 @@ struct IVirtualBox_vtbl
>> Â{
>> Â Â Âstruct nsISupports_vtbl nsisupports;
>>
>> +# Âifdef WIN32
>> + Â Â/* The MSCOM implementation has some additional methods here.
>> + Â Â * So add them here to get correct binary layout of the object.
>> + Â Â * In API version 2.2 this affects IVirtualBox and ISession only. */
>> + Â Ânsresult PR_COM_METHOD (*GetTypeInfoCount)(IVirtualBox *pThis);
>> + Â Ânsresult PR_COM_METHOD (*GetTypeInfo)(IVirtualBox *pThis);
>> + Â Ânsresult PR_COM_METHOD (*GetIDsOfNames)(IVirtualBox *pThis);
>> + Â Ânsresult PR_COM_METHOD (*Invoke)(IVirtualBox *pThis);
>> +# Âendif
>
> ACK. ÂHmm, I'm wondering if MSCOM is usable under cygwin, in which case
> you might have to adjust the #ifdef WIN32 into #if defined WIN32 ||
> defined __CYGWIN; but that change should come later only after someone
> reports needing it to build vbox support into cygwin libvirt.
>

Thanks, pushed.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]