2010/12/17 Eric Blake <eblake@xxxxxxxxxx>:
> On 12/17/2010 08:59 AM, Matthias Bolte wrote:
>> ---
>> Âtests/qemuargv2xmltest.c | Â Â1 +
>> Âtests/qemuhelptest.c   |  Â5 +++--
>> Âtests/qemuxml2argvtest.c | Â Â8 +++++---
>> Âtests/testutilsqemu.c  Â|  Â6 ++----
>> Â4 files changed, 11 insertions(+), 9 deletions(-)
>
> ACK. ÂFixes the problems I identified yesterday.
Thanks, but Daniel fixed it in the meantime :)
>> diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c
>> index 72fc8aa..bfac307 100644
>> --- a/tests/testutilsqemu.c
>> +++ b/tests/testutilsqemu.c
>> @@ -8,6 +8,7 @@
>> Â# include "memory.h"
>> Â# include "cpu_conf.h"
>> Â# include "qemu/qemu_driver.h"
>> +# include "qemu/qemu_domain.h"
>>
>> Âstatic virCapsGuestMachinePtr *testQemuAllocMachines(int *nmachines)
>> Â{
>> @@ -102,10 +103,7 @@ virCapsPtr testQemuCapsInit(void) {
>> Â Â Â Â Â(machines = testQemuAllocMachines(&nmachines)) == NULL)
>> Â Â Â Â Âgoto cleanup;
>>
>> - Â Âcaps->ns.parse = qemuDomainDefNamespaceParse;
>> - Â Âcaps->ns.free = qemuDomainDefNamespaceFree;
>> - Â Âcaps->ns.format = qemuDomainDefNamespaceFormatXML;
>> - Â Âcaps->ns.href = qemuDomainDefNamespaceHref;
>> + Â ÂqemuDomainSetNamespaceHooks(caps);
>
> Ah, much nicer than my futile attempts at removing the 'static' modifier
> from the now-private functions.
At first I tried that too, until I noticed qemuDomainSetNamespaceHooks :)
Matthias
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list