On 12/16/2010 12:26 PM, Daniel P. Berrange wrote: > On Thu, Dec 16, 2010 at 12:13:51PM -0700, Eric Blake wrote: >> On 12/16/2010 09:50 AM, Daniel P. Berrange wrote: >>> Allow QEMU driver files access to qemuDomainObjPrivate struct >>> >>> * src/qemu/qemu_conf.h: Add qemuDomainObjPrivate struct >>> * src/qemu/qemu_driver.c: Remove qemuDomainObjPrivate struct >>> --- >>> src/qemu/qemu_driver.c | 45 --------------------------------------------- >>> 1 files changed, 0 insertions(+), 45 deletions(-) >> >> The diffstat doesn't agree with the commit message. And it fails to >> compile for me; even after manually doing what your commit message >> claimed, the failure was that qemuMonitorPtr was not available in >> qemu_conf.h. > > Hmm, seems this went wrong during a rebase. The qemu_conf.h > addition somehow ended up in the next patch. I should just > squash the patches 3 & 4 together I wondered that too, at first, but the diffstat for 4 doesn't concur either: src/qemu/qemu_conf.h | 3 - At any rate, if I paste the 45 lines, and add #include "qemu_monitor.h" at the top, then things compile, but I don't know if you wanted qemu_monitor.h dragging that in for all clients of qemu_conf.h. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list