On 12/10/2010 05:07 PM, Eric Blake wrote: > * src/util/util.h (virWaitPid): New prototype. > * src/util/util.c (virWaitPid): Implement it. > * src/util/command.c (virCommandWait): Use it. > * src/libvirt_private.syms: Export it. > --- > > Should I convert over most remaining instances of waitpid() and > add a 'make syntax-check' entry? The only place that can't > convert is lxc_controller.c (it uses WNOHANG instead of 0), but > lxc is already Linux-specific, so it can be exempted from a > syntax-check. self-NACK. Gnulib provides a waitpid() module, that we should just use instead of redoing it ourselves. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list