On 12/07/2010 09:05 AM, Dan Kenigsberg wrote: > starting a service during rpm installation is impolite. It is even worse if done > during upgrade, for a service that was explicitly turned off. > --- > libvirt.spec.in | 8 +++++--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index 48453d7..e0cab78 100644 > --- a/libvirt.spec.in > +++ b/libvirt.spec.in > @@ -700,9 +700,11 @@ fi > /sbin/ldconfig > /sbin/chkconfig --add libvirt-guests > if [ $1 -ge 1 ]; then > - # this doesn't do anything but allowing for libvirt-guests to be > - # stopped on the first shutdown > - /sbin/service libvirt-guests start > /dev/null 2>&1 || true > + if /sbin/chkconfig --list libvirt-guests | /bin/grep -q :on ; then grep -q is not POSIX, but then again, in a spec file, where you can assume chkconfig exists, you can assume grep -q exists. I was going to suggest saving a process: case $(/sbin/chkconfig --list libvirt-guests) in *:on*) ... esac but it's not worth it, for how seldom the shell code in a spec file is run. > + # this doesn't do anything but allowing for libvirt-guests to be > + # stopped on the first shutdown > + /sbin/service libvirt-guests start > /dev/null 2>&1 || true > + fi > fi ACK, and pushed as-is. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list