On 12/09/2010 12:13 PM, Eric Blake wrote: > On 12/09/2010 04:09 AM, Daniel P. Berrange wrote: >> On Mon, Dec 06, 2010 at 04:24:09PM +0900, MORITA Kazutaka wrote: >>> This patch adds network disk support to libvirt/QEMU. The currently >>> supported protocols are nbd, rbd, and sheepdog. The XML syntax is like >>> this: >>> > >> ACK > > NACK. After applying this patch, I get 'make check' failures: > > TEST: vmx2xmltest > /bin/sh: line 5: 15285 Segmentation fault (core dumped) Weird. After 'make clean', I was no longer able to reproduce the failure; I then did a complete fresh checkout to verify on a pristine tree. I must have had some bad cruft lying around in my tree, and wonder what it was about your patch to expose that cruft? At any rate, given that your patch does not fail after all, I will go ahead and push it. However, we still need a follow-up patch: > Hmm; missing a corresponding update to docs/formatdomain.html.in to > document the new XML. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list