On Fri, Dec 03, 2010 at 02:56:17PM -0700, Eric Blake wrote: > * src/conf/domain_conf.c (virDomainDefParseXML): Prefer sysinfo > uuid over generating one, and if both uuids are present, require > them to be identical. > * src/qemu/qemu_conf.c (qemuBuildSmbiosSystemStr): Allow skipping > the uuid. > (qemudBuildCommandLine): Adjust caller; <smbios mode=host/> must > not use host uuid in place of guest uuid. > --- > > The qemu developers pointed out that '-uuid xyz' and '-smbios > type=1,uuid=xyz' both have the same effect. They argued that -uuid is > deprecated, but it's easier for libvirt to always supply it. > Meanwhile, they were clear that if both values were supplied, the two > uuids had better be identical (current qemu favors -uuid over -smbios, > but it's not guaranteed to stay that way in the future). in practice I ended up at least on one test where -uuid and <smbios mode=host/> failed with the code in qemu complaining that the UUID was not well formed, so yes that's a good thing ! ACK Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list