Re: [PATCH] virsh: Remove redundant optional option for cmdHelp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




-    name = vshCommandOptString(cmd, "command", NULL);
-
-    if (!name)
-        name = vshCommandOptString(cmd, "group", NULL);
+    name = vshCommandOptString(cmd, "command-or-group", NULL);

NACK.  This breaks backwards compatibility for anyone with scripts already using "--command":


Don't think anyone really used "--command", our test programs
even doesn't use it.

So then it's reasonable to be consistent, as virsh supports
both command and command group now, and actually I save
you pushed the doc patch.

Regards

- Osier

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]