Re: [PATCH v4 RESEND 1/4] threadpool impl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 02, 2010 at 12:28:17PM +0000, Daniel P. Berrange wrote:
<...snip...>
> > +
> > +        if (virThreadCreate(&pool->workers[pool->nWorkers - 1],
> > +                            true,
> > +                            virThreadPoolWorker,
> > +                            pool) < 0) {
> > +            pool->nWorkers--;
> > +            goto error;
> > +        }
> 
> Small typo, that check should "!= NULL", rather than "< 0".

Confused. Do you mean virThreadCreate() or VIR_ALLOC() below? But both
return int.

> 
> > +    }
> > +
> > +    if (VIR_ALLOC(job) < 0) {
> > +        virReportOOMError();
> > +        goto error;
> > +    }

-- 
Thanks,
Hu Tao

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]