On Wed, Dec 01, 2010 at 12:21:51PM -0700, Eric Blake wrote:
> On 12/01/2010 10:26 AM, Daniel P. Berrange wrote:
> > The logging setup requires const char * strings, but the
> > virLogSetFromEnv() strdup's the env variables, thus causing
> > a memory leak
> >
> > * src/util/logging.c: Avoid strdup'ing env variables
> > ---
> > src/util/logging.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/util/logging.c b/src/util/logging.c
> > index d65dec0..83cc358 100644
> > --- a/src/util/logging.c
> > +++ b/src/util/logging.c
> > @@ -980,8 +980,8 @@ void virLogSetFromEnv(void) {
> > virLogParseDefaultPriority(debugEnv);
> > debugEnv = getenv("LIBVIRT_LOG_FILTERS");
> > if (debugEnv && *debugEnv)
> > - virLogParseFilters(strdup(debugEnv));
> > + virLogParseFilters(debugEnv);
>
> ACK; independently useful to push now, even if the rest of your series
> is not ready for prime time.
Yep, pushed that
Daniel
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list