On 12/01/2010 05:12 PM, Eric Blake wrote:
> * docs/schemas/domain.rng (sysinfo-system-name): Also allow
> family.
Unfortunately, <sysinfo> and <smbios> were never documented in
docs/formatdomain.html.in; we'll have to add that before we can add
<entry name='family'>string</entry> to that documentation.
> +++ b/tests/qemuxml2argvdata/qemuxml2argv-smbios.xml
> @@ -15,6 +15,8 @@
> <entry name="version">0.8.2-3.fc14</entry>
> <entry name="serial">32dfcb37-5af1-552b-357c-be8c3aa38310</entry>
> <entry name="uuid">c7a5fdbd-edaf-9455-926a-d65c16db1809</entry>
> + <entry name="sku">1234567890</entry>
> + <entry name="family">Red Hat</entry>
Don't we typically use '' rather than "" for attribute values? We
should probably fix that to be consistent as well.
Another problem I just noticed - I can't roundtrip from <smbios
mode='host'/> back to the full-blown <smbios mode='sysinfo'/> on my
laptop, because my laptop has the following dmidecode entries:
Handle 0x0000, DMI type 0, 24 bytes
Vendor: LENOVO
Version: 6FET82WW (3.12 )
Release Date: 11/26/2009
BIOS Revision: 3.18
Handle 0x0100, DMI type 1, 27 bytes
Manufacturer: LENOVO
Product Name: 2241B36
Version: ThinkPad T500
Serial Number: R89055N
UUID: E321ED02-FAC8-9337-B0E7-C3B32580E899
SKU Number: Not Specified
Family: Red Hat Enterprise Linux
but the schema only allows:
<define name="sysinfo-value">
<data type="string">
<param name='pattern'>[a-zA-Z0-9/\-_\. ]+</param>
</data>
</define>
which rejects my Version string in block 0.
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list