On 12/01/2010 09:44 AM, Matthias Bolte wrote: > 2010/11/30 Eric Blake <eblake@xxxxxxxxxx>: >> * src/qemu/qemu_driver.c (qemudShutdown): Free all strings and the >> ebtables structure. >> * src/libvirt_private.syms (ebtablesContextFree): Export missing >> symbol. >> * src/util/ebtables.c (ebtablesContextFree): Allow early exit. >> --- >> >> This leak triggers on every start/stop of a qemu domain, although >> it typically accounts for less than 1k leak per sequence. >> > >> VIR_FREE(qemu_driver->hugepage_path); >> >> + VIR_FREE(qemu_driver->securityDriverName); > > Any specific reason for this empty line in this block of free calls? Only because that was a place where the list of items being freed didn't directly correspond to the declaration order within the struct, whereas the earlier list had pretty much been done in the same order. Not much reason for either keeping or deleting it, since it's just cosmetic. So I deleted it. :) > > ACK. Thanks; I've pushed 6 and 7 now. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list