> > tests/nwfilterxml2xmltest.c | 15 +++++----------
> > tests/qemuxml2argvtest.c | 8 +++-----
> > 2 files changed, 8 insertions(+), 15 deletions(-)
>
> ACK to the patch as is. It fixes the problem
Thanks, I pushed it.
> qemudBuildCommandLine returns 0 and reports and error. Actually it
> doesn't report an error, because then it should return non-zero. What
> it does in the 3 cases where the test expects and "error" it reports
> actually a warning. For example this one:
>
> qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED,
> _("the QEMU binary %s does not support kvm"),
> emulator);
>
> This is currently reported at error level (VIR_ERR_ERROR) but it
> should actually be reported at warning level (VIR_ERR_WARNING),
> because it's treated as non-fatal.
Yeah, there's a whole bunch of such errors in qemudBuildCommandLine which
don't really result in returning an error code. These should all be changed to
warnings.
I'll prepare a patch for this after the release.
Jirka
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list