Re: [PATCH 4/n] storage: plug memory leak on error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/11/24 Eric Blake <eblake@xxxxxxxxxx>:
> * src/storage/storage_backend.c
> (virStorageBackendUpdateVolTargetInfoFD): Avoid leak.
> ---
>
> Unlikely to bite in real life, but still a leak.
>
> Âsrc/storage/storage_backend.c | Â Â2 +-
> Â1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c
> index a6ee564..10ea33c 100644
> --- a/src/storage/storage_backend.c
> +++ b/src/storage/storage_backend.c
> @@ -1148,11 +1148,11 @@ virStorageBackendUpdateVolTargetInfoFD(virStorageVolTargetPtr target,
> Â Â Â Â }
> Â Â } else {
> Â Â Â Â target->perms.label = strdup(filecon);
> + Â Â Â Âfreecon(filecon);
> Â Â Â Â if (target->perms.label == NULL) {
> Â Â Â Â Â Â virReportOOMError();
> Â Â Â Â Â Â return -1;
> Â Â Â Â }
> - Â Â Â Âfreecon(filecon);
> Â Â }
> Â#else
> Â Â target->perms.label = NULL;
> --
> 1.7.3.2
>

ACK.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]