Re: [PATCH] remote: Fix TLS transport on Windows

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/11/22 Eric Blake <eblake@xxxxxxxxxx>:
> On 11/22/2010 02:50 PM, Matthias Bolte wrote:
>> I just used what'a in curl, as directly casting from void* to int
>> would give this error on 64bit platform:
>>
>> Â error: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>
> And casting to long is no better on windows (where long is still 32-bit
> even though pointers are 64-bit).
>
>>
>> (Yes, this is tested on Linux 64bit, as I didn't setup mingw-w64 yet)
>>
>> Casting to size_t works too.
>
> Not only does it avoid the warning, but it also matches the signature of
> send() and recv().
>
>>
>> Here's a v2 that casts to size_t and has an improved commit message.
>
> ACK.
>

Thanks, pushed.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]