The virFork call resets all logging handlers that may have been
set. Re-enable them after fork in virExec, so that env variables
fir LIBVIRT_LOG_OUTPUTS and LIBVIRT_LOG_FILTERS take effect
until the execve()
* src/util/util.c: Preserve logging in child in virExec
---
src/util/util.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/util/util.c b/src/util/util.c
index f2fe58a..a0849e1 100644
--- a/src/util/util.c
+++ b/src/util/util.c
@@ -602,6 +602,9 @@ __virExec(const char *const*argv,
childout = -1;
}
+ /* Initialize full logging for a while */
+ virLogSetFromEnv();
+
/* Daemonize as late as possible, so the parent process can detect
* the above errors with wait* */
if (flags & VIR_EXEC_DAEMON) {
@@ -650,6 +653,9 @@ __virExec(const char *const*argv,
virClearCapabilities() < 0)
goto fork_error;
+ /* Close logging again to ensure no FDs leak to child */
+ virLogReset();
+
if (envp)
execve(argv[0], (char **) argv, (char**)envp);
else
--
1.7.2.3
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list