On 11/13/2010 05:04 PM, Stefan Berger wrote: > On 11/13/2010 04:52 PM, Eric Blake wrote: >> * src/nwfilter/nwfilter_ebiptables_driver.c >> (ebiptablesWriteToTempFile): Use /bin/sh. >> (bash_cmd_path): Delete. >> (ebiptablesDriverInit, ebiptablesDriverShutdown): No need to >> search for bash. >> (CMD_EXEC): Prefer $() over ``, since we can assume POSIX. >> (iptablesSetupVirtInPost): Use portable 'test' syntax. >> (iptablesLinkIPTablesBaseChain): Use POSIX $(()) syntax. > > Since you are the expert with shells and I trust that the TCK tests now > pass with all possible /bin/sh's, you get my ACK. Well, at least with all POSIX-compliant /bin/sh, which is what Linux is likely to have, and nwfilter requires Linux. It won't work with Solaris /bin/sh, but that's a much harder portability target since it is so old (bourne shell, which pre-dates POSIX). But thankfully not an issue for this patch. I've gone ahead and pushed it. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list