Re: [PATCH] esx: Avoid warnings about breaking strict-aliasing rules on FreeBSD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/11/13 Eric Blake <eblake@xxxxxxxxxx>:
> On 11/13/2010 08:53 AM, Matthias Bolte wrote:
>> ---
>> Âsrc/esx/esx_vi_generator.py | Â 10 ++++++++--
>> Â1 files changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/esx/esx_vi_generator.py b/src/esx/esx_vi_generator.py
>> index c2f7044..01636aa 100755
>> --- a/src/esx/esx_vi_generator.py
>> +++ b/src/esx/esx_vi_generator.py
>> @@ -699,7 +699,10 @@ class Object:
>>
>> Â Â Â Â Â Â Âif self.features & Object.FEATURE__LIST:
>> Â Â Â Â Â Â Â Â Âif self.extends is not None:
>> - Â Â Â Â Â Â Â Â Â Âsource += " Â ÂesxVI_%s_Free((esxVI_%s **)&item->_next);\n\n" % (self.extends, self.extends)
>> + Â Â Â Â Â Â Â Â Â Â# avoid "dereferencing type-punned pointer will break strict-aliasing rules" warnings
>> + Â Â Â Â Â Â Â Â Â Âsource += " Â ÂesxVI_%s *next = (esxVI_%s *)item->_next;\n\n" % (self.extends, self.extends)
>> + Â Â Â Â Â Â Â Â Â Âsource += " Â ÂesxVI_%s_Free(&next);\n" % self.extends
>> + Â Â Â Â Â Â Â Â Â Âsource += " Â Âitem->_next = (esxVI_%s *)next;\n\n" % self.name
>
> ACK.
>

Thanks, pushed.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]