On Fri, Nov 12, 2010 at 06:37:36PM +0000, Daniel P. Berrange wrote: > On Fri, Nov 12, 2010 at 12:39:57PM -0500, Dave Allan wrote: > > On Fri, Nov 12, 2010 at 04:22:35PM +0000, Daniel P. Berrange wrote: > > > The following series of patches are adding significant > > > extra functionality to the iSCSI driver. THe current > > > internal helper methods are not sufficiently flexible > > > to cope with these changes. This patch refactors the > > > code to avoid needing to have a virStoragePoolObjPtr > > > instance as a parameter, instead passing individual > > > target, portal and initiatoriqn parameters. > > > > What's your motivation for removing the struct and passing the > > parameters individually? It's clearly not wrong, but why generate the > > code churn if it's not required? > > The storage pool discovery code in a following patch does > not have any virStoragePoolObjPtr available, since its > very purpose is to discover one ! LOL, indeed, that's a good reason. Dave -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list