On Wed, Oct 20, 2010 at 10:34:00AM +0200, Daniel Veillard wrote:
> Looks just fine, applied and pushed !
Was just working on some changes for qemu; looking at this fresh made me
notice I'd overlooked the unnecessary quoting of the command line. AFAICT
the quoting isn't necessary.
john
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 9e6e162..85e5998 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -4224,7 +4224,7 @@ int qemudBuildCommandLine(virConnectPtr conn,
if (driver->setProcessName &&
(qemuCmdFlags & QEMUD_CMD_FLAG_NAME_PROCESS)) {
char *name;
- if (virAsprintf(&name, "%s,process=\"qemu:%s\"",
+ if (virAsprintf(&name, "%s,process=qemu:%s",
def->name, def->name) < 0)
goto no_memory;
ADD_ARG_LIT(name);
--
John Morrissey _o /\ ---- __o
jwm@xxxxxxxxx _-< \_ / \ ---- < \,
www.horde.net/ __(_)/_(_)________/ \_______(_) /_(_)__
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list