Re: [PATCH] Allow virDomainGetMemoryParameters on read-only connections

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/11/8 Daniel Veillard <veillard@xxxxxxxxxx>:
> On Sun, Nov 07, 2010 at 01:38:22PM +0100, Matthias Bolte wrote:
>> Also fix a typo in the documentation of the function.
>> ---
>> Âsrc/libvirt.c | Â Â6 +-----
>> Â1 files changed, 1 insertions(+), 5 deletions(-)
>>
>> diff --git a/src/libvirt.c b/src/libvirt.c
>> index aebd3bc..2ffb2d9 100644
>> --- a/src/libvirt.c
>> +++ b/src/libvirt.c
>> @@ -3096,7 +3096,7 @@ error:
>> Â * }
>> Â *
>> Â * This function requires privileged access to the hypervisor. This function
>> - * expects the caller to allocate the @param
>> + * expects the caller to allocate the @params.
>> Â *
>> Â * Returns -1 in case of error, 0 in case of success.
>> Â */
>> @@ -3115,10 +3115,6 @@ virDomainGetMemoryParameters(virDomainPtr domain,
>> Â Â Â Â ÂvirDispatchError(NULL);
>> Â Â Â Â Âreturn -1;
>> Â Â Â}
>> - Â Âif (domain->conn->flags & VIR_CONNECT_RO) {
>> - Â Â Â ÂvirLibDomainError(domain, VIR_ERR_OPERATION_DENIED, __FUNCTION__);
>> - Â Â Â Âgoto error;
>> - Â Â}
>> Â Â Âif ((nparams == NULL) || (*nparams < 0)) {
>> Â Â Â Â ÂvirLibDomainError(domain, VIR_ERR_INVALID_ARG, __FUNCTION__);
>> Â Â Â Â Âgoto error;
>
> ÂACK,
>
> Daniel

Thanks, pushed.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]