On Tue, Nov 02, 2010 at 05:49:15PM +0000, Daniel P. Berrange wrote: > * src/lxc/lxc_driver.c, src/lxc/lxc_driver.c, > src/xen/xen_driver.c: Wire up virDomainOpenConsole > --- > src/lxc/lxc_driver.c | 67 ++++++++++++++++++++++++++++++++++++++++++- > src/uml/uml_driver.c | 77 ++++++++++++++++++++++++++++++++++++++++++++++---- > src/xen/xen_driver.c | 59 +++++++++++++++++++++++++++++++++++++- > 3 files changed, 195 insertions(+), 8 deletions(-) > [...] > + > + if (chr->type != VIR_DOMAIN_CHR_TYPE_PTY) { > + umlReportError(VIR_ERR_INTERNAL_ERROR, > + _("character device %s is not using a PTY"), devname); > + goto cleanup; > + } just wondering, why would that happen ? ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list