On Tue, Nov 02, 2010 at 05:36:48PM +0100, Daniel Veillard wrote: > @@ -4092,6 +4171,44 @@ int qemudBuildCommandLine(virConnectPtr conn, > } > } > > + if ((def->smbios_mode != VIR_DOMAIN_SMBIOS_NONE) && > + (def->smbios_mode != VIR_DOMAIN_SMBIOS_EMULATE) && > + (qemuCmdFlags & QEMUD_CMD_FLAG_SMBIOS_TYPE)) { It would be to report a VIR_ERR_CONFIG_UNSUPPORTED error in the else clause for this. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list