On Mon, Nov 01, 2010 at 11:32:25AM +0100, Diego Elio Pettenà wrote: > Il giorno lun, 01/11/2010 alle 10.26 +0000, Daniel P. Berrange ha > scritto: > > > > This introduces a strict coupling between the usb + cgroups > > code which isn't something we want. Using the usbDeviceFileIterate > > API avoids this coupling. > > > Okay I'll rework this today; for now at least I guess my users won't > find themselves stonewalled by libvirt :P > > > One general point is that the indentation in your patch is not > > correct - needs to be 4 space indented rather than 2. See the > > HACKING file for .emacs rules. > > Gha missed that; would it be useful if I sent a patch to add > a .dir-locals.el so that us Emacs users would get it out of the box? ;) Sure, sounds fine. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list