On Thu, Oct 28, 2010 at 07:26:41PM +0900, KAMEZAWA Hiroyuki wrote: > >From 4f74c4a69785432258ad5ea5e695d1b94aaa5b30 Mon Sep 17 00:00:00 2001 > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > Date: Thu, 28 Oct 2010 16:31:46 +0900 > Subject: [PATCH 1/2] add compression support for "virsh dump" > > Add dump_image_format[] to qemu.conf and support compressed dump > at virsh dump. coredump compression is important for saving disk space > in an environment where multiple guests run. > > In general, "disk space for dump" is specially allocated and will be > a dead space in the system. It's used only at emergency. So, it's better > to have both of save_image_format and dump_image_format. "save" is done > in scheduled manner with enough calculated disk space for it. > > This code reuses some of save_image_format[] and supports the same format. > > Changelog: > - modified libvirtd_qemu.aug > - modified test_libvirtd_qemu.aug > - fixed error handling of qemudSaveCompressionTypeFromString() > --- > src/qemu/libvirtd_qemu.aug | 1 + > src/qemu/qemu.conf | 4 +++ > src/qemu/qemu_conf.c | 11 ++++++++++ > src/qemu/qemu_conf.h | 1 + > src/qemu/qemu_driver.c | 41 ++++++++++++++++++++++++++++++++------ > src/qemu/test_libvirtd_qemu.aug | 2 + > 6 files changed, 53 insertions(+), 7 deletions(-) ACK, looks good. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list