On Fri, Oct 29, 2010 at 04:53:11PM +0800, Osier Yang wrote:
> * src/qemu/qemu_driver.c (qemuDomainManagedSavePath)
> ---
> src/qemu/qemu_driver.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 89b4d11..976fb72 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -5843,6 +5843,7 @@ qemuDomainManagedSavePath(struct qemud_driver *driver, virDomainObjPtr vm) {
> char *ret;
>
> if (virAsprintf(&ret, "%s/%s.save", driver->saveDir, vm->def->name) < 0) {
> + VIR_FREE(ret);
> virReportOOMError();
> return(NULL);
> }
No need for this. virAsprintf() guarentees that &ret is NULL upon failure
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list