Re: [PATCH] show compiled in options in virsh --version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric Blake wrote:
> [adding bug-gnulib]
>
> On 10/28/2010 01:25 PM, Daniel Veillard wrote:
>>>>          case 'v':
>>>> -            /* FIXME - list a copyright blurb, as in GNU programs?  */
>>>> -            puts(VERSION);
>>>> +            vshShowVersion(ctl);
>>>>              exit(EXIT_SUCCESS);
>>>
>>> Pre-existing bug - we don't detect write failure to stdout to exit with
>>> non-zero status.  Unchanged by your patch.
>>
>>   Not sure it's really a problem, but okay I will look.
>
> The gnulib module closeout can automatically take care of this, but it
> is currently licensed as GPL.  Jim, Bruno, are you okay with relicensing
> closeout and close-stream as LGPLv2+?

They're both relatively thin wrappers.
Fine by me.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]