On Wed, Oct 27, 2010 at 08:20:09AM -0600, Eric Blake wrote:
> * docs/api_extension/{0013,0014}*.patch: Rename to shorter files.
> * docs/api_extension.html.in: Reflect rename.
> ---
>
> > Ouch, it turns out it breaks "make dist" on Fedora 13.
>
> Not just Fedora 13, but everywhere. This is the easiest fix.
>
> docs/api_extension.html.in | 4 ++--
> ...13-of-15-improve-getting-xen-vcpu-counts.patch} | 0
> ...14-of-15-improve-setting-xen-vcpu-counts.patch} | 0
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename docs/api_extension/{0013-Step-13-of-15-improve-support-for-getting-xen-vcpu-counts.patch => 0013-Step-13-of-15-improve-getting-xen-vcpu-counts.patch} (100%)
> rename docs/api_extension/{0014-Step-14-of-15-improve-support-for-setting-xen-vcpu-counts.patch => 0014-Step-14-of-15-improve-setting-xen-vcpu-counts.patch} (100%)
>
> diff --git a/docs/api_extension.html.in b/docs/api_extension.html.in
> index 6a99cd9..9d033bc 100644
> --- a/docs/api_extension.html.in
> +++ b/docs/api_extension.html.in
> @@ -412,8 +412,8 @@
> </p>
>
> <p class="example">See <a href="api_extension/0012-Step-12-of-15-improve-vcpu-support-in-xen-command-line.patch">0012-Step-12-of-15-improve-vcpu-support-in-xen-command-line.patch</a>,
> - <a href="api_extension/0013-Step-13-of-15-improve-support-for-getting-xen-vcpu-counts.patch">0013-Step-13-of-15-improve-support-for-getting-xen-vcpu-counts.patch</a>,
> - <a href="api_extension/0014-Step-14-of-15-improve-support-for-setting-xen-vcpu-counts.patch">0014-Step-14-of-15-improve-support-for-setting-xen-vcpu-counts.patch</a>,
> + <a href="api_extension/0013-Step-13-of-15-improve-getting-xen-vcpu-counts.patch">0013-Step-13-of-15-improve-getting-xen-vcpu-counts.patch</a>,
> + <a href="api_extension/0014-Step-14-of-15-improve-setting-xen-vcpu-counts.patch">0014-Step-14-of-15-improve-setting-xen-vcpu-counts.patch</a>,
> and <a href="api_extension/0015-Step-15-of-15-remove-dead-xen-code.patch">0015-Step-15-of-15-remove-dead-xen-code.patch</a></p>
>
> <p>
> diff --git a/docs/api_extension/0013-Step-13-of-15-improve-support-for-getting-xen-vcpu-counts.patch b/docs/api_extension/0013-Step-13-of-15-improve-getting-xen-vcpu-counts.patch
> similarity index 100%
> rename from docs/api_extension/0013-Step-13-of-15-improve-support-for-getting-xen-vcpu-counts.patch
> rename to docs/api_extension/0013-Step-13-of-15-improve-getting-xen-vcpu-counts.patch
> diff --git a/docs/api_extension/0014-Step-14-of-15-improve-support-for-setting-xen-vcpu-counts.patch b/docs/api_extension/0014-Step-14-of-15-improve-setting-xen-vcpu-counts.patch
> similarity index 100%
> rename from docs/api_extension/0014-Step-14-of-15-improve-support-for-setting-xen-vcpu-counts.patch
> rename to docs/api_extension/0014-Step-14-of-15-improve-setting-xen-vcpu-counts.patch
Having both '0014' and 'Step-14-of-15' in the filename seems like over
rather overkill to me. I'd remove the 'Step-14-of-15' bit and just
leave the patch number
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list