On Tue, Oct 19, 2010 at 07:53:47AM -0600, Eric Blake wrote: > On 10/19/2010 07:34 AM, Daniel Veillard wrote: > >On Fri, Oct 15, 2010 at 06:06:26PM -0400, Stefan Berger wrote: > >> V3: > >> - many small nits addressed > >> > >> V2: > >> - following Eric's suggestions and picking up his code suggestions > >> > >>Since bugs due to double-closed file descriptors are difficult to > >>track down in a multi-threaded system, I am introducing the > >>VIR_CLOSE(fd) macro to help avoid mistakes here. > >> > >>There are lots of places where close() is being used. In this patch > >>I am only cleaning up usage of close() in src/conf where the > >>problems were. > >> > >>I also dare to declare close() as being deprecated in libvirt code > >>base (HACKING). > >> > >>Signed-off-by: Stefan Berger<stefanb@xxxxxxxxxx> > > > > ACK, let's the cleanup begin ... > > Did we want a v4, now that "ignore-value.h" has been fixed? I see the v4 ended in my inbox, in the meantime, so yes :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list