Re: [PATCH] esx: Handle Windows-1252 encoded VMX files

Matthias Bolte <matthias.bolte@xxxxxxxxxxxxxx> · Sat, 16 Oct 2010 20:45:05 +0200

2010/10/16 Matthias Bolte <matthias.bolte@xxxxxxxxxxxxxx>:
> ESX(i) uses UTF-8, but a Windows based GSX server writes
> Windows-1252 encoded VMX files.
> ---
> Âsrc/esx/esx_util.c Â | Â 48 +++++++++++++++++++++++++++++++++++++++++++++---
> Âsrc/esx/esx_util.h Â | Â Â2 ++
> Âsrc/esx/esx_vmx.c Â Â| Â 33 +++++++++++++++++++++++++++++++++
> Âtests/esxutilstest.c | Â 41 +++++++++++++++++++++++++++++++++++++++++
> Â4 files changed, 121 insertions(+), 3 deletions(-)
>

I hit the send button to early... Why limit this to Windows-1252
encoding when it could accept all encodings that libxml2 (using
libiconv/glibc) can convert to UTF-8. Therefore, this patch is
replaced with a more general one:

  https://www.redhat.com/archives/libvir-list/2010-October/msg00517.html

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list