Re: [PATCH] esx: Fix check in esxDomainGetInfo's perf metric handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/10/15 Eric Blake <eblake@xxxxxxxxxx>:
> On 10/15/2010 12:47 PM, Matthias Bolte wrote:
>>
>> ---
>> Âsrc/esx/esx_driver.c | Â Â8 +++++---
>> Â1 files changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
>> index 8bc3be2..1b4ee29 100644
>> --- a/src/esx/esx_driver.c
>> +++ b/src/esx/esx_driver.c
>> @@ -2329,15 +2329,17 @@ esxDomainGetInfo(virDomainPtr domain,
>> virDomainInfoPtr info)
>> Â Â Â Â Â Â Â Â ÂperfEntityMetric =
>>
>> ÂesxVI_PerfEntityMetric_DynamicCast(perfEntityMetricBase);
>>
>> - Â Â Â Â Â Â Â Âif (perfMetricIntSeries == NULL) {
>> - Â Â Â Â Â Â Â Â Â ÂVIR_ERROR0(_("QueryPerf returned object with
>> unexpected type"));
>> + Â Â Â Â Â Â Â Âif (perfEntityMetric == NULL) {
>> + Â Â Â Â Â Â Â Â Â ÂVIR_ERROR(_("QueryPerf returned object with
>> unexpected type '%s'"),
>> +
>> ÂesxVI_Type_ToString(perfEntityMetricBase->_type));
>> Â Â Â Â Â Â Â Â Â}
>>
>> Â Â Â Â Â Â Â Â ÂperfMetricIntSeries =
>>
>> ÂesxVI_PerfMetricIntSeries_DynamicCast(perfEntityMetric->value);
>
> ACK - looks like a copy-and-paste fix, in the category of "how did it ever
> possibly work when it was originally committed?".
>

Exactly :)

Thanks, pushed.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]